DATAVIZ-2220: Fix multiple subtree tilesets #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmanley
approved these changes
Nov 16, 2023
| @@ -10,12 +10,12 @@ import Long from 'long'; | |||
| import {Tiles3DLoaderOptions} from '../../../tiles-3d-loader'; | |||
| import {ImplicitOptions} from '../parse-3d-tile-header'; | |||
|
|
|||
| const QUADTREE_DEVISION_COUNT = 4; | |||
| const OCTREE_DEVISION_COUNT = 8; | |||
| const QUADTREE_DIVISION_COUNT = 4; | |||
Gmadges
approved these changes
Nov 21, 2023
Pull Request Test Coverage Report for Build 6972434665
💛 - Coveralls |
Kaapp
added a commit
that referenced
this pull request
Dec 6, 2023
…ilesets DATAVIZ-2220: Fix multiple subtree tilesets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with tilesets with multiple subtrees there was a bug with
globalDatabeing passed by reference along the recursion meaning that when reaching the bottom of the depth-first search, the values would not be reset appropriately when pursuing the next path. This meant that the wrong subtrees would be requested.Additionally, when requesting tiles from a subtree they would be incorrectly indexed as the global x/y/z coordinates were being incorrectly shifted.
Lastly, when dealing with sparse tilesets, there was an issue causing a large number of failed requests to the base URL of the tileset. Instead, if a tile has no content, do not make a request.